model(cdc): add a function to recover TiDB TableInfo #7480
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
cdc/entry/mounter_test.go
Outdated
| " c3 BIT(10) NOT NULL," + | ||
| " UNIQUE KEY (c2, c3)" + | ||
| ")", | ||
| // CDC discards field length, charset and collation. |
There was a problem hiding this comment.
discard field length will cause correctness problem like #3286
Signed-off-by: lance6716 <lance6716@gmail.com>
|
ptal @asddongmen |
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #7480 +/- ##
================================================
+ Coverage 59.8150% 59.8923% +0.0773%
================================================
Files 803 802 -1
Lines 92129 92182 +53
================================================
+ Hits 55107 55210 +103
+ Misses 32213 32158 -55
- Partials 4809 4814 +5 |
| indexInfo.Columns = append(indexInfo.Columns, indexCol) | ||
| } | ||
|
|
||
| // TODO: revert the "all column set index related flag" to "only the |
There was a problem hiding this comment.
Does this TODO item need to be done in this PR?
There was a problem hiding this comment.
No, I'll test if this reversion is really needed in future PR
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 6350b95
|
ti-chi-bot
added
the
status/can-merge
What problem does this PR solve?
Issue Number: ref #3242, a part of #4587
What is changed and how it works?
after recover TiDB TableInfo from CDC's redo log or RowChangedEvent, we can use sqlmodel and generate DML in the same way as DM
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note